ext/block: do not suppress device-removed event on VM shutdown

[marmarek]

Send all device-removed events on VM shutdown, skip only detaching
devices, not events.

QubesOS/qubes-issues#8537

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.84%. Comparing base (ef09d2e) to head (9d27f7f).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
qubes/ext/block.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
- Coverage   70.90%   70.84%   -0.06%     
==========================================
  Files          61       61              
  Lines       13465    13465              
==========================================
- Hits         9547     9539       -8     
- Misses       3918     3926       +8     

Flag	Coverage Δ
unittests	70.84% <0.00%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[qubesos-bot]

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025071903-4.3&flavor=pull-requests

Test run included the following:

• Fix clearing available devices cache on domain shutdown qubes-app-linux-usb-proxy#48 (QubesOS/qubes-app-linux-usb-proxy@dbe1cb0)
• Disallow dangerous qrexec operations qubes-core-admin-addon-whonix#22 (QubesOS/qubes-core-admin-addon-whonix@43b89db)
• Set NetVM and DispVM properly for StandaloneVMs qubes-core-admin-addon-whonix#23 (QubesOS/qubes-core-admin-addon-whonix@c0dce5f)
• Add Arch packaging qubes-core-admin-client#332 (QubesOS/qubes-core-admin-client@40487bc)
• Improve device category description qubes-core-admin-client#362 (QubesOS/qubes-core-admin-client@5902314)
• Cleanup qmemman #694 (05c3799)
• Ease debugging Windows VM #701 (9f5152f)
• Set less memory to preload before pausing #702 (1032e83)
• ext/block: do not suppress device-removed event on VM shutdown #704 (9d27f7f)
• Use new API in the Devices Widget qubes-desktop-linux-manager#267 (QubesOS/qubes-desktop-linux-manager@3710003)
• Optimize SVG icons qubes-desktop-linux-menu#57 (QubesOS/qubes-desktop-linux-menu@aa4fdf6)
• Don't try to send grants for not realized windows qubes-gui-agent-linux#236 (QubesOS/qubes-gui-agent-linux@0fc7bb1)
• Connect vchan to GUI domain instead of dom0 qubes-gui-agent-windows#7 (QubesOS/qubes-gui-agent-windows@b904d94)
• Ignore RemoteVM for now qubes-manager#398 (QubesOS/qubes-manager@679eff4)
• Prioritize sys-usb before other autostarted VMs qubes-mgmt-salt-dom0-virtual-machines#76 (QubesOS/qubes-mgmt-salt-dom0-virtual-machines@e4ae100)
• Update PV drivers qubes-vmm-xen-windows-pvdrivers#4 (QubesOS/qubes-vmm-xen-windows-pvdrivers@377ccb4)

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

• system_tests_pvgrub_salt_storage

  • TC_42_PVHGrub_debian-12-xfce: test_010_template_based_vm (error + cleanup)
    raise TimeoutError from exc_val... TimeoutError

• system_tests_dispvm

  • TC_20_DispVM_whonix-workstation-17: test_030_edit_file (failure + cleanup)
    AssertionError: Timeout while waiting for disp[0-9]* window to show

  • TC_20_DispVM_whonix-workstation-17: test_100_open_in_dispvm (failure + cleanup)
    AssertionError: Timeout while waiting for disp[0-9]* window to show

• system_tests_devices

  • TC_00_List_whonix-gateway-17: test_011_list_dm_mounted (failure)
    AssertionError: 'test-dm' == 'test-dm' : Device test-inst-vm:dm-0::...

• system_tests_audio@hw1

  • TC_20_AudioVM_PipeWire_fedora-42-xfce: test_226_audio_playback_pipewire (error + cleanup)
    raise TimeoutError from exc_val... TimeoutError

• system_tests_qwt_win10_seamless@hw13

  • windows_install: Failed (test died)
    # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

• system_tests_qwt_win11@hw13

  • windows_install: Failed (test died)
    # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

Failed tests

10 failures

• system_tests_pvgrub_salt_storage

  • TC_42_PVHGrub_debian-12-xfce: test_010_template_based_vm (error + cleanup)
    raise TimeoutError from exc_val... TimeoutError

• system_tests_extra

  • TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
    AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...

• system_tests_dispvm

  • TC_20_DispVM_whonix-workstation-17: test_030_edit_file (failure + cleanup)
    AssertionError: Timeout while waiting for disp[0-9]* window to show

  • TC_20_DispVM_whonix-workstation-17: test_100_open_in_dispvm (failure + cleanup)
    AssertionError: Timeout while waiting for disp[0-9]* window to show

• system_tests_devices

  • TC_00_List_whonix-gateway-17: test_011_list_dm_mounted (failure)
    AssertionError: 'test-dm' == 'test-dm' : Device test-inst-vm:dm-0::...

• system_tests_kde_gui_interactive

  • gui_keyboard_layout: wait_serial (wait serial expected)
    # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

  • gui_keyboard_layout: Failed (test died)
    # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

• system_tests_audio@hw1

  • TC_20_AudioVM_PipeWire_fedora-42-xfce: test_226_audio_playback_pipewire (error + cleanup)
    raise TimeoutError from exc_val... TimeoutError

• system_tests_qwt_win10_seamless@hw13

  • windows_install: Failed (test died)
    # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

• system_tests_qwt_win11@hw13

  • windows_install: Failed (test died)
    # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

10 fixed

• system_tests_extra

  • TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

• system_tests_audio

  • TC_20_AudioVM_Pulse_debian-12-xfce: test_252_audio_playback_audiovm_switch_hvm (failure)
    AssertionError: only silence detected, no useful audio data

  • TC_20_AudioVM_Pulse_whonix-workstation-17: test_225_audio_rec_unmuted_hvm (failure)
    AssertionError: too short audio, expected 10s, got 7.95233560090703...

• system_tests_splitgpg

  • TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

• system_tests_guivm_vnc_gui_interactive

  • simple_gui_apps: unnamed test (unknown)
  • simple_gui_apps: Failed (test died)
    # Test died: no candidate needle with tag(s) 'vm-settings-applicati...

Unstable tests

Performance Tests

Performance degradation:

9 performance degradations

• debian-12-xfce_exec-data-simplex: 72.42 🔺 ( previous job: 65.51, degradation: 110.54%)
• debian-12-xfce_exec-data-duplex-root: 82.28 🔺 ( previous job: 70.01, degradation: 117.53%)
• whonix-gateway-17_exec-root: 43.81 🔺 ( previous job: 39.57, degradation: 110.71%)
• whonix-gateway-17_socket: 9.83 🔺 ( previous job: 7.85, degradation: 125.16%)
• whonix-gateway-17_socket-root: 8.70 🔺 ( previous job: 7.89, degradation: 110.24%)
• whonix-gateway-17_exec-data-duplex-root: 101.47 🔺 ( previous job: 90.74, degradation: 111.83%)
• dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 253646.00 :small_red_triangle: ( previous job: 289982.00, degradation: 87.47%)
• dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 14119.00 :small_red_triangle: ( previous job: 17102.00, degradation: 82.56%)
• dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 105280.00 :small_red_triangle: ( previous job: 122848.00, degradation: 85.70%)

Remaining performance tests:

63 tests

• debian-12-xfce_exec: 7.29 🟢 ( previous job: 8.63, improvement: 84.48%)
• debian-12-xfce_exec-root: 29.21 🟢 ( previous job: 29.44, improvement: 99.24%)
• debian-12-xfce_socket: 8.96 🔺 ( previous job: 8.50, degradation: 105.43%)
• debian-12-xfce_socket-root: 8.56 🔺 ( previous job: 8.31, degradation: 102.94%)
• debian-12-xfce_exec-data-duplex: 67.72 🟢 ( previous job: 73.55, improvement: 92.08%)
• debian-12-xfce_socket-data-duplex: 160.98 🟢 ( previous job: 161.35, improvement: 99.77%)
• fedora-42-xfce_exec: 9.10
• fedora-42-xfce_exec-root: 58.04
• fedora-42-xfce_socket: 8.05
• fedora-42-xfce_socket-root: 8.53
• fedora-42-xfce_exec-data-simplex: 69.44
• fedora-42-xfce_exec-data-duplex: 71.77
• fedora-42-xfce_exec-data-duplex-root: 98.53
• fedora-42-xfce_socket-data-duplex: 156.15
• whonix-gateway-17_exec: 6.91 🟢 ( previous job: 7.34, improvement: 94.14%)
• whonix-gateway-17_exec-data-simplex: 78.89 🔺 ( previous job: 77.76, degradation: 101.45%)
• whonix-gateway-17_exec-data-duplex: 82.13 🔺 ( previous job: 78.39, degradation: 104.78%)
• whonix-gateway-17_socket-data-duplex: 169.74 🔺 ( previous job: 161.95, degradation: 104.81%)
• whonix-workstation-17_exec: 7.73 🟢 ( previous job: 8.27, improvement: 93.38%)
• whonix-workstation-17_exec-root: 58.83 🔺 ( previous job: 57.61, degradation: 102.11%)
• whonix-workstation-17_socket: 8.78 🟢 ( previous job: 8.97, improvement: 97.90%)
• whonix-workstation-17_socket-root: 10.34 🔺 ( previous job: 9.46, degradation: 109.33%)
• whonix-workstation-17_exec-data-simplex: 62.25 🟢 ( previous job: 74.54, improvement: 83.51%)
• whonix-workstation-17_exec-data-duplex: 81.62 🔺 ( previous job: 74.84, degradation: 109.07%)
• whonix-workstation-17_exec-data-duplex-root: 86.93 🔺 ( previous job: 86.00, degradation: 101.08%)
• whonix-workstation-17_socket-data-duplex: 169.35 🔺 ( previous job: 160.20, degradation: 105.71%)
• dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 135279.00 :green_circle: ( previous job: 101988.00, improvement: 132.64%)
• dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 56932.00 :green_circle: ( previous job: 14284.00, improvement: 398.57%)
• dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 38763.00 :green_circle: ( previous job: 32696.00, improvement: 118.56%)
• dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 1354.00 :green_circle: ( previous job: 1091.00, improvement: 124.11%)
• dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 11835.00 :green_circle: ( previous job: 11086.00, improvement: 106.76%)
• dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 4559.00 :green_circle: ( previous job: 1840.00, improvement: 247.77%)
• dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 500991.00 :green_circle: ( previous job: 289182.00, improvement: 173.24%)
• dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 439286.00 :green_circle: ( previous job: 433654.00, improvement: 101.30%)
• dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 157711.00 :small_red_triangle: ( previous job: 167872.00, degradation: 93.95%)
• dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 103257.00 :small_red_triangle: ( previous job: 108760.00, degradation: 94.94%)
• dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 9261.00 :green_circle: ( previous job: 8874.00, improvement: 104.36%)
• dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 7920.00 :green_circle: ( previous job: 6356.00, improvement: 124.61%)
• dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4954.00 :green_circle: ( previous job: 4420.00, improvement: 112.08%)
• fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 387786.00
• fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 274280.00
• fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 308223.00
• fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 139265.00
• fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 83540.00
• fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 5449.00
• fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8108.00
• fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 2626.00
• fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 334154.00
• fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 225791.00
• fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 281044.00
• fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 125146.00
• fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 36961.00
• fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 2612.00
• fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8504.00
• fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1051.00
• fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 346293.00
• fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 208754.00
• fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 292489.00
• fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 106325.00
• fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 46029.00
• fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 2084.00
• fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8014.00
• fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1975.00