Skip to content

Conversation

ben-grande
Copy link
Contributor

For: QubesOS/qubes-issues#1512


Missed this on #686.

@ben-grande ben-grande marked this pull request as ready for review July 11, 2025 06:31
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.84%. Comparing base (9952998) to head (d592878).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #700      +/-   ##
==========================================
- Coverage   70.89%   70.84%   -0.06%     
==========================================
  Files          61       61              
  Lines       13463    13465       +2     
==========================================
- Hits         9545     9539       -6     
- Misses       3918     3926       +8     
Flag Coverage Δ
unittests 70.84% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@marmarek marmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some places you check klass to be AppVM, and in others name to be "dom0", please make it consistent, one way or the other.

@ben-grande ben-grande force-pushed the preload-global-autostart branch from 48c15b9 to aefece3 Compare July 20, 2025 16:31
@ben-grande ben-grande force-pushed the preload-global-autostart branch from aefece3 to d592878 Compare July 20, 2025 18:22
@marmarek marmarek merged commit f83a2a2 into QubesOS:main Jul 20, 2025
3 of 5 checks passed
@qubesos-bot
Copy link

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025072015-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

  • system_tests_basic_vm_qrexec_gui

  • system_tests_extra

    • TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
      ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0
  • system_tests_network_updates

    • TC_10_QvmTemplate_whonix-gateway-17: test_010_template_install (failure)
      qvm-template: error: Template 'debian-12-minimal' not found.
  • system_tests_qwt_win10_seamless@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
  • system_tests_qwt_win11@hw13

    • windows_install: wait_serial (wait serial expected)
      # wait_serial expected: qr/qDqV_-\d+-/...

    • windows_install: Failed (test died + timed out)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

Failed tests

9 failures
  • system_tests_basic_vm_qrexec_gui

  • system_tests_extra

    • TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
      ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0

    • TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
      AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...

  • system_tests_network_updates

    • TC_10_QvmTemplate_whonix-gateway-17: test_010_template_install (failure)
      qvm-template: error: Template 'debian-12-minimal' not found.
  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_qwt_win10_seamless@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
  • system_tests_qwt_win11@hw13

    • windows_install: wait_serial (wait serial expected)
      # wait_serial expected: qr/qDqV_-\d+-/...

    • windows_install: Failed (test died + timed out)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

10 fixed

Unstable tests

Performance Tests

Performance degradation:

8 performance degradations
  • debian-12-xfce_exec-data-simplex: 74.91 🔺 ( previous job: 65.51, degradation: 114.34%)
  • whonix-gateway-17_exec: 9.01 🔺 ( previous job: 7.34, degradation: 122.76%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 2108.00 :small_red_triangle: ( previous job: 11086.00, degradation: 19.01%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 429.00 :small_red_triangle: ( previous job: 1840.00, degradation: 23.32%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 63937.00 :small_red_triangle: ( previous job: 122848.00, degradation: 52.05%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 248007.00 :small_red_triangle: ( previous job: 433654.00, degradation: 57.19%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 7876.00 :small_red_triangle: ( previous job: 8874.00, degradation: 88.75%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 3555.00 :small_red_triangle: ( previous job: 4420.00, degradation: 80.43%)

Remaining performance tests:

64 tests
  • debian-12-xfce_exec: 6.97 🟢 ( previous job: 8.63, improvement: 80.75%)
  • debian-12-xfce_exec-root: 28.55 🟢 ( previous job: 29.44, improvement: 96.99%)
  • debian-12-xfce_socket: 7.83 🟢 ( previous job: 8.50, improvement: 92.15%)
  • debian-12-xfce_socket-root: 7.76 🟢 ( previous job: 8.31, improvement: 93.35%)
  • debian-12-xfce_exec-data-duplex: 75.32 🔺 ( previous job: 73.55, degradation: 102.42%)
  • debian-12-xfce_exec-data-duplex-root: 71.30 🔺 ( previous job: 70.01, degradation: 101.84%)
  • debian-12-xfce_socket-data-duplex: 159.26 🟢 ( previous job: 161.35, improvement: 98.70%)
  • fedora-42-xfce_exec: 9.15
  • fedora-42-xfce_exec-root: 58.93
  • fedora-42-xfce_socket: 7.97
  • fedora-42-xfce_socket-root: 8.19
  • fedora-42-xfce_exec-data-simplex: 66.35
  • fedora-42-xfce_exec-data-duplex: 70.03
  • fedora-42-xfce_exec-data-duplex-root: 93.60
  • fedora-42-xfce_socket-data-duplex: 134.97
  • whonix-gateway-17_exec-root: 38.42 🟢 ( previous job: 39.57, improvement: 97.08%)
  • whonix-gateway-17_socket: 7.46 🟢 ( previous job: 7.85, improvement: 94.95%)
  • whonix-gateway-17_socket-root: 6.83 🟢 ( previous job: 7.89, improvement: 86.58%)
  • whonix-gateway-17_exec-data-simplex: 73.35 🟢 ( previous job: 77.76, improvement: 94.32%)
  • whonix-gateway-17_exec-data-duplex: 68.00 🟢 ( previous job: 78.39, improvement: 86.76%)
  • whonix-gateway-17_exec-data-duplex-root: 91.19 🔺 ( previous job: 90.74, degradation: 100.49%)
  • whonix-gateway-17_socket-data-duplex: 171.19 🔺 ( previous job: 161.95, degradation: 105.71%)
  • whonix-workstation-17_exec: 8.52 🔺 ( previous job: 8.27, degradation: 102.91%)
  • whonix-workstation-17_exec-root: 57.09 🟢 ( previous job: 57.61, improvement: 99.11%)
  • whonix-workstation-17_socket: 8.23 🟢 ( previous job: 8.97, improvement: 91.74%)
  • whonix-workstation-17_socket-root: 8.73 🟢 ( previous job: 9.46, improvement: 92.28%)
  • whonix-workstation-17_exec-data-simplex: 64.84 🟢 ( previous job: 74.54, improvement: 86.99%)
  • whonix-workstation-17_exec-data-duplex: 66.22 🟢 ( previous job: 74.84, improvement: 88.48%)
  • whonix-workstation-17_exec-data-duplex-root: 92.66 🔺 ( previous job: 86.00, degradation: 107.75%)
  • whonix-workstation-17_socket-data-duplex: 156.94 🟢 ( previous job: 160.20, improvement: 97.97%)
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 492751.00 :green_circle: ( previous job: 289982.00, improvement: 169.92%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 245108.00 :green_circle: ( previous job: 101988.00, improvement: 240.33%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 398546.00 :green_circle: ( previous job: 14284.00, improvement: 2790.16%)
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 56472.00 :green_circle: ( previous job: 32696.00, improvement: 172.72%)
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 21679.00 :green_circle: ( previous job: 17102.00, improvement: 126.76%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 5659.00 :green_circle: ( previous job: 1091.00, improvement: 518.70%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 422302.00 :green_circle: ( previous job: 289182.00, improvement: 146.03%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 205535.00 :green_circle: ( previous job: 167872.00, improvement: 122.44%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 103264.00 :small_red_triangle: ( previous job: 108760.00, degradation: 94.95%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 7727.00 :green_circle: ( previous job: 6356.00, improvement: 121.57%)
  • fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 350811.00
  • fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 263792.00
  • fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 310505.00
  • fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 127286.00
  • fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 84208.00
  • fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2299.00
  • fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8831.00
  • fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 950.00
  • fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 384657.00
  • fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 170599.00
  • fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 265664.00
  • fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 98049.00
  • fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 37224.00
  • fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 3942.00
  • fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 7896.00
  • fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1431.00
  • fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 386073.00
  • fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 128405.00
  • fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 346636.00
  • fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 24598.00
  • fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 85272.00
  • fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 4030.00
  • fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8343.00
  • fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 701.00

@ben-grande
Copy link
Contributor Author

ben-grande commented Jul 21, 2025 via email

ben-grande added a commit to ben-grande/qubes-core-admin that referenced this pull request Jul 22, 2025
ben-grande added a commit to ben-grande/qubes-core-admin that referenced this pull request Jul 22, 2025
ben-grande added a commit to ben-grande/qubes-core-admin that referenced this pull request Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants