gui: set guivm windows prefix and default_guivm tag #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
+ Coverage 62.32% 62.32% +<.01%
==========================================
Files 49 49
Lines 8653 8656 +3
==========================================
+ Hits 5393 5395 +2
- Misses 3260 3261 +1
Continue to review full report at Codecov.
|
marmarek
requested changes
Nov 7, 2019
qubes/ext/gui.py
Outdated
|
|
||
| # Set GuiVM prefix | ||
| guivm_windows_prefix = vm.features.get('guivm-windows-prefix', 'GuiVM') | ||
| if vm.features.get('service.guivm-gui-agent', None) == '1': |
There was a problem hiding this comment.
It doesn't need to be 1 (in practice it is, but lets be consistent). Technically it can be any value and should be evaluated to true/false according to python rules. In short: drop == '1'.
fepitre
changed the title
fepitre
force-pushed
the
guivm2
branch
2 times, most recently
from
85ca503
to
e4d3e35
Compare
marmarek
requested changes
Nov 11, 2019
marmarek
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QubesOS/qubes-issues#4186
QubesOS/qubes-issues#5662
QubesOS/qubes-issues#833