Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GuiVM #287

Merged
merged 8 commits into from
Oct 22, 2019
Merged

GuiVM #287

merged 8 commits into from
Oct 22, 2019

Conversation

fepitre
Copy link
Member

@fepitre fepitre commented Oct 19, 2019

Copy link
Member

@marmarek marmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also separate code style changes and functional changes into separate commits.

qubes/vm/qubesvm.py Outdated Show resolved Hide resolved
qubes/ext/gui.py Outdated Show resolved Hide resolved
qubes/ext/gui.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 20, 2019

Codecov Report

Merging #287 into master will increase coverage by 0.07%.
The diff coverage is 74.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   62.16%   62.24%   +0.07%     
==========================================
  Files          49       49              
  Lines        8604     8621      +17     
==========================================
+ Hits         5349     5366      +17     
  Misses       3255     3255
Flag Coverage Δ
#unittests 62.24% <74.02%> (+0.07%) ⬆️
Impacted Files Coverage Δ
qubes/vm/qubesvm.py 47.77% <58.33%> (+0.3%) ⬆️
qubes/ext/gui.py 88% <86.66%> (-2.91%) ⬇️
qubes/app.py 73.02% <88.46%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f4b5d...7c85568. Read the comment docs.

@fepitre fepitre changed the title WIP: guivm GuiVM Oct 20, 2019
qubes/app.py Outdated Show resolved Hide resolved
qubes/tests/vm/qubesvm.py Outdated Show resolved Hide resolved
@marmarek marmarek merged commit 7c85568 into QubesOS:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants