Make the qubes-pciback module omittable #178
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
=======================================
Coverage 73.03% 73.03%
=======================================
Files 10 10
Lines 1157 1157
=======================================
Hits 845 845
Misses 312 312 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025012120-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update
Failed tests50 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/119126#dependencies 3 fixed
Unstable testsDetails |
4 participants
On my system I have an alternative solution to
qubes-pciback, which allows fido2 disk crypto (and fixes a hardware specific issue QubesOS/qubes-issues#8794). Unfortunately it's not compatible withqubes-pciback.The problem I'm having with
qubes-pcibackis that it's included twice into dracut:check()function inmodule-setup.sh, which defaults to include by default).dracut.conf.d/30-qubes.conf.The
check()function can be overridden usingomit_dracutmodules+=, butadd_dracutmodules+=can't. Since30-qubes.confis managed by dnf/rpm, changes to it are volatile, meaning that any setup which requiresqubes-pcibackto be disabled breaks wheneverqubes-core-dom0-adminis updated.This pull request removes
qubes-pcibackfrom30-qubes.confand adds an explicitcheck()function to the module which includesqubes-pcibackby default. As far as I can tell from my testing and from the documentation, this will retain the exact previous behavior unless the user addsomit_dracutmodules+=" qubes-pciback "to a dracut config file.