Skip to content

Deserialize device in events only if there is a handler registered #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marmarek wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Deserialize device in events only if there is a handler registered #402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions qubesadmin/events/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,15 @@ def handle(self, subject, event, **kwargs):
except KeyError:
pass

handlers = [h_func for h_name, h_func_set in self.handlers.items()
for h_func in h_func_set
if fnmatch.fnmatch(event, h_name)]

# skip deserializing parameters (which may make further Admin API calls)
# if no handler is registered for the event
if not handlers:
return

# deserialize known attributes
if event.startswith('device-'):
try:
Expand Down Expand Up @@ -292,9 +301,6 @@ def handle(self, subject, event, **kwargs):
except (KeyError, ValueError):
pass

handlers = [h_func for h_name, h_func_set in self.handlers.items()
for h_func in h_func_set
if fnmatch.fnmatch(event, h_name)]
for handler in handlers:
try:
handler(subject, event, **kwargs)
Expand Down