device identity #304
Open
device identity #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrbartman
force-pushed
the
qdev/devel
branch
from
9a7ff4b
to
0168517
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
==========================================
+ Coverage 75.09% 75.23% +0.13%
==========================================
Files 52 52
Lines 8541 8799 +258
==========================================
+ Hits 6414 6620 +206
- Misses 2127 2179 +52 ☔ View full report in Codecov by Sentry. |
piotrbartman
force-pushed
the
qdev/devel
branch
from
2c86f03
to
2db1c50
Compare
1. `ask-to-attach` is not even implemented for PCI (assigned devices will be ignored) 2. manual attaching could lead to unusable devices 3. `auto-attach` there is no good reason for ignoring absent of PCI device
If front-vm is down, we still want assignment
Listing all assignments by default could be overwhelming. Now to see all assignment a flag `-s` must be used. Assignments are indicated by '*' before qube name.
Even if device is `auto-attached` it could be manually reattached, so to avoid confusion just show as `attached`
piotrbartman
force-pushed
the
qdev/devel
branch
from
22aac29
to
05115ae
Compare
|
Changes here looks okay, but I haven't tried running this version yet. |
|
Important note on breaking backward compatibility: there may exists scripts using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements QubesOS/qubes-issues/issues/9325