You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to need allow_fullscreen. I'd rather not add it to sys-gui because then it's becomes problematic to test it when running a normal session. Added an override: qvm-start-daemon --allow-fullscreen.
Remaining issues:
Selecting "Logout" in sys-gui seems to shut down the Xephyr window but not the VM. Should it work that way? Should we detect that the GUI agent inside has died and then exit dom0 session, or rather make the VM shut down?
I'm doing it as a special option to qvm-start-daemon instead of
changing the option globally for sys-gui, because I want sys-gui
windows to be also usable in normal XFCE session, e.g. for
development.
This seems to need allow_fullscreen. I'd rather not add it to sys-gui because then it's becomes problematic to test it when running a normal session. Added an override: qvm-start-daemon --allow-fullscreen.
After discussing: remove --allow-fullscreen and the permission for sys-gui globally in Salt configuration.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pwmarcz
force-pushed
the
gui-session
branch
3 times, most recently
from
Starts just sys-gui VM and qvm-start-daemon in a special mode.
See QubesOS/qubes-issues#5662.
This seems to need
allow_fullscreen. I'd rather not add it tosys-guibecause then it's becomes problematic to test it when running a normal session. Added an override:qvm-start-daemon --allow-fullscreen.Remaining issues:
sys-guiseems to shut down the Xephyr window but not the VM. Should it work that way? Should we detect that the GUI agent inside has died and then exit dom0 session, or rather make the VM shut down?