Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] enable alternative installation and log path #1288

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shrik3
Copy link
Collaborator

@shrik3 shrik3 commented May 24, 2024

motivation:
(especially for development) we don't want to use sudo all the time. Also it doesn't make sense to hardcode the paths in the program.

what's changing:
the makefile no longer uses sudo for the install target, you may need to run sudo make install if make install fails. Otherwise nothing changes if you don't modify the makefile.

how to install to custom paths:
modify the makefile, and quark will use these paths for qkernel, vdso.so binary paths, config path and log path.

export PREFIX          ?= /home/shrik3/.local
export QBIN_DIR        ?= $(PREFIX)/bin
export QCONFIG_DIR     ?= /home/shrik3/.config/quark
export QLOG_DIR        ?= /tmp/log/quark

and modify the /etc/docker/daemon.json accordingly.

limitations

  1. quark doesn't create the QLOG_DIR (yet). We can do it in the makefile.
  2. other logs such as used by qservice are still created under the default path /var/log/quark but they can opt in pretty easily.

qvisor/src/main.rs Outdated Show resolved Hide resolved
makefile Outdated Show resolved Hide resolved
Signed-off-by: Tianhao Wang <shrik3@mailbox.org>
Signed-off-by: Tianhao Wang <shrik3@mailbox.org>
Signed-off-by: Tianhao Wang <shrik3@mailbox.org>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a condition to check which files to copy over? It is annoying to get false negatives. I have a (semi) fix for that in the previous version, maybe do something similar.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants