Skip to content

Conversation

Jutho
Copy link
Member

@Jutho Jutho commented Oct 17, 2024

This contains two commits, which should not be squashed.

  1. this changes the strided implementation so as to always specialise, getting rid of small allocations and some overhead for small permutations
  2. this abolishes the get_extension trick in the extensions which started to break on Julia 1.11.1, and simplifies the rrules for the tensor operations so that also other packages (i.e. TensorKit) should not rely on that same broken trick to overload the rrules

Along the way, it also fixes the blas_contract overload in the bumper extension so that it actually gets used.

@Jutho
Copy link
Member Author

Jutho commented Oct 18, 2024

Failures on x86 with Julia 1(.11) are CUDA related.

@maleadt
Copy link

maleadt commented Oct 18, 2024

I take it this fixes the LoadError: StridedViewsCUDAExt not found observed in JuliaGPU/CUDA.jl#2525?

@Jutho
Copy link
Member Author

Jutho commented Oct 18, 2024

Yes, that was another consequence of the "extension loading during precompilation" change in Julia 1.11.1

@Jutho Jutho merged commit 2a56132 into master Oct 18, 2024
16 of 18 checks passed
@Jutho Jutho deleted the jh/v5.1 branch October 18, 2024 08:58
@maleadt
Copy link

maleadt commented Oct 18, 2024

Thanks! Do you plan to put this in a release anytime soon?

@Jutho
Copy link
Member Author

Jutho commented Oct 18, 2024

Yes, I want to test one more thing this afternoon, and then I will tag the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants