Change conj flags from Symbol to Bool
#176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jutho
reviewed
Jun 11, 2024
| Alias for supported label containers. | ||
| """ | ||
| const Labels{I<:LabelType} = Union{Tuple{Vararg{I}},AbstractVector{I}} |
There was a problem hiding this comment.
This excludes things like [1,3,:x,:a] but I guess that is acceptable. We can always recommend tuples, as (1,3,:x,'a') isa Labels is still true.
There was a problem hiding this comment.
collect(LabelType, [1, 2, :x, :a]) should also still work in that case :)
|
While I do think that code clarity is slightly reduced here and there compared to the explicit use of N and C (as |
Jutho
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the usage of conj flags by replacing the symbols with booleans. This is especially useful in AD, where comparing and negating with booleans is more convenient.
Importantly, as a
Boolis a subtype ofNumber, this introduces some method ambiguities for the functions syntax, which is resolved by restricting the types of the labels to be aTupleorAbstractVectorofInt,SymbolorChar.