Refactor branching on α and β
#146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkdvos
commented
Sep 11, 2023
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
==========================================
+ Coverage 81.17% 81.55% +0.37%
==========================================
Files 25 25
Lines 2189 2152 -37
==========================================
- Hits 1777 1755 -22
+ Misses 412 397 -15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
`op1 = Base.Fix2(scale, α) ∘ *` instead of `op1 = (x, y) -> scale(x * y, α)`
lkdvos
changed the title
α and β
|
Looks great. Should we try to resolve the type piracy and update StridedViews.jl (I would put it there rather than in Strided.jl)? Or do we leave that for another time? |
lkdvos
force-pushed
the
dynamic-zeros
branch
2 times, most recently
from
9185608 to
ee58074
Compare
lkdvos
force-pushed
the
dynamic-zeros
branch
from
ee58074 to
b8221e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies some implementations that are checking for dynamic zeros/ones, in favor of only special-casing the statically known ones and letting the compiler const-propagate the rest.