-
Notifications
You must be signed in to change notification settings - Fork 55
Refactor test suite #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Refactor test suite #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
e75541b to
6d590f0
Compare
Member
Author
|
Had to patch the parsing due to QuantumKitHub/TensorKitSectors.jl#32 |
cbc3942 to
745b665
Compare
Jutho
reviewed
Oct 24, 2025
Jutho
reviewed
Oct 24, 2025
Jutho
reviewed
Oct 24, 2025
Jutho
reviewed
Oct 24, 2025
Jutho
reviewed
Oct 24, 2025
Jutho
reviewed
Oct 24, 2025
Jutho
reviewed
Oct 24, 2025
Member
|
Thanks for this; this looks great. I left a few small comments. |
Member
Author
|
I think all comments have been addressed here, all this needs is an approval and it should merge as soon as the tests pass. |
Jutho
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates out some of the parts of the test suite in order to increase parallelism on the github runners, and get slightly better feedback on where things went wrong if they did.
The main idea is to organize the tests into groups, as dictated by a folder structure, and then the QuantumKitHubActions workflow takes care of the rest. Additionally, you can control them from the local command line through:
which would run only the
other/andsymmetries/tests.I've made sure that the individual files are all self-contained as well, so a workflow like this also works:
Obviously the split I chose is arbitrary, and I'm happy to rethink all of the names.
This also tackles some issues we had with the CompatCheck workflow
This also fixes a breaking change we accidentally slipped in with the TensorKitSectors v0.3.1 changes.