Skip to content

Conversation

@kshyatt
Copy link
Member

@kshyatt kshyatt commented Aug 21, 2025

Seems to avoid the LoadError but of course I'm still learning my way around so the correctness may not be there yet 😅

@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.39%. Comparing base (b9f874d) to head (b6b9874).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   82.85%   83.39%   +0.53%     
==========================================
  Files          44       44              
  Lines        5757     5757              
==========================================
+ Hits         4770     4801      +31     
+ Misses        987      956      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos
Copy link
Member

lkdvos commented Aug 21, 2025

I've not checked this in detail but that definitely looks correct, I compared with the TensorOperations use of that function and that seems reasonable.
One thing to try out here is to just locally see if the MPSKit tests run, to double check everything is okay?

@kshyatt
Copy link
Member Author

kshyatt commented Aug 21, 2025

MPSKit.jl tests passed locally for me

@lkdvos lkdvos merged commit 60c7f4d into QuantumKitHub:master Aug 21, 2025
16 of 18 checks passed
@kshyatt kshyatt deleted the ksh/sum branch August 21, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants