Excise MatrixAlgebra module entirely to use MatrixAlgebraKit#272
Merged
lkdvos merged 4 commits intoQuantumKitHub:matrixalgebrafrom Aug 21, 2025
Merged
Excise MatrixAlgebra module entirely to use MatrixAlgebraKit#272lkdvos merged 4 commits intoQuantumKitHub:matrixalgebrafrom
lkdvos merged 4 commits intoQuantumKitHub:matrixalgebrafrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## matrixalgebra #272 +/- ##
=================================================
+ Coverage 78.02% 80.12% +2.10%
=================================================
Files 49 49
Lines 5760 5570 -190
=================================================
- Hits 4494 4463 -31
+ Misses 1266 1107 -159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lkdvos
reviewed
Aug 21, 2025
Member
lkdvos
left a comment
There was a problem hiding this comment.
Left some small comments, happy to already merge this though if you prefer. I definitely like this, it's great that we no longer need this module!
Member
Author
|
OK, all comments resolved, should be good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved
one!andsafesignout, changed a few calls toleftorth!, and thetensorsanddiagonaltests passed locally for me. Hopefully this won't break anything downstream...