Skip to content

Excise MatrixAlgebra module entirely to use MatrixAlgebraKit#272

Merged
lkdvos merged 4 commits intoQuantumKitHub:matrixalgebrafrom
kshyatt:ksh/surgery
Aug 21, 2025
Merged

Excise MatrixAlgebra module entirely to use MatrixAlgebraKit#272
lkdvos merged 4 commits intoQuantumKitHub:matrixalgebrafrom
kshyatt:ksh/surgery

Conversation

@kshyatt
Copy link
Member

@kshyatt kshyatt commented Aug 21, 2025

Moved one! and safesign out, changed a few calls to leftorth!, and the tensors and diagonal tests passed locally for me. Hopefully this won't break anything downstream...

@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.12%. Comparing base (8549b2a) to head (59bdfd8).
⚠️ Report is 5 commits behind head on matrixalgebra.

Files with missing lines Patch % Lines
src/tensors/factorizations/factorizations.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           matrixalgebra     #272      +/-   ##
=================================================
+ Coverage          78.02%   80.12%   +2.10%     
=================================================
  Files                 49       49              
  Lines               5760     5570     -190     
=================================================
- Hits                4494     4463      -31     
+ Misses              1266     1107     -159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments, happy to already merge this though if you prefer. I definitely like this, it's great that we no longer need this module!

@kshyatt
Copy link
Member Author

kshyatt commented Aug 21, 2025

OK, all comments resolved, should be good to go

@lkdvos lkdvos merged commit 113f9a1 into QuantumKitHub:matrixalgebra Aug 21, 2025
13 checks passed
@kshyatt kshyatt deleted the ksh/surgery branch August 21, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants