-
Notifications
You must be signed in to change notification settings - Fork 27
Add tests for C4vCTMRG gradients #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+193
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
reviewed
Feb 11, 2026
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
lkdvos
approved these changes
Feb 11, 2026
Member
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Member
Author
|
I opened issues to track the failing cases, so we can merge this to add coverage for the working cases already and then sort out the failures later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds gradient tests for C4v CTMRG contraction.
There seem to be a few combinations that don't work right now. In particular, while the naive
gradient_alg = nothingalways work, fixed-point differentiation using a:fulleigh reverse rule or adiffgaugeiteration scheme give incorrect gradients. I marked these cases as broken for now to make sure this is tracked at least. If it's unclear how these can be fixed right now, we can open issues to track this and then merge the tests like this I think.I also made some minor modifications to the fixed-point differentiation implementations, most notably moving the definition of the iterating function and its pullback outside of the actual
leading_boundary_pullbackfunction body. I'm not sure if this makes a difference in practice, but this looks a bit more intuitive to me. I also modified theEigSolverimplementation offpgradto useVectorInterface.addinstead of+and*, to make it easier to use this with other environment types.