-
Notifications
You must be signed in to change notification settings - Fork 5
Refactor truncation module + add truncerror
#55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
1022ad7 to
da2c0dc
Compare
Great, it will be nice to have a shared implementation to use.
|
|
Great PR. One thing it does not address is (not saying that it should) is that in the AD rules for truncated factorizations, I will need to reproduce the logic of |
* Refactor truncation implementation * relax norm types * Add TruncationError * update docs * Add some tests * move definition of `&` * Add `notrunc` docstrings * update `findtruncated_sorted` docstring
This PR slightly refactors the truncation implementation, by separating out the interface from the implementation, more similar to the other parts of the library.
Additionally, I ported over
truncerror(TruncationError), based on TensorKit.jl and TensorAlgebra.jlI tentatively renamed it from
truncerrtotruncerror, I'm not sure how useful it is to shorten that name further. Happy to change that back if we don't like this.