Use Testsuite for AD tests by kshyatt · Pull Request #126 · QuantumKitHub/MatrixAlgebraKit.jl

kshyatt · 2025-12-23T07:58:13Z

This lets us reuse a lot of the setup infrastructure for ChainRules, Mooncake, and (soon) Enzyme. Also starts testing the AD rules on GPU.

ext/MatrixAlgebraKitCUDAExt/MatrixAlgebraKitCUDAExt.jl

github-actions · 2025-12-23T10:11:12Z

Your PR no longer requires formatting changes. Thank you for your contribution!

codecov · 2026-01-19T15:29:52Z

Codecov Report

❌ Patch coverage is 82.72727% with 19 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ixAlgebraKitAMDGPUExt/MatrixAlgebraKitAMDGPUExt.jl	0.00%	4 Missing ⚠️
...MatrixAlgebraKitCUDAExt/MatrixAlgebraKitCUDAExt.jl	0.00%	4 Missing ⚠️
src/pullbacks/lq.jl	88.46%	3 Missing ⚠️
src/pullbacks/qr.jl	88.46%	3 Missing ⚠️
ext/MatrixAlgebraKitChainRulesCoreExt.jl	85.71%	2 Missing ⚠️
src/pullbacks/eig.jl	88.88%	1 Missing ⚠️
src/pullbacks/eigh.jl	88.88%	1 Missing ⚠️
src/pullbacks/svd.jl	90.90%	1 Missing ⚠️

Files with missing lines	Coverage Δ
...gebraKitMooncakeExt/MatrixAlgebraKitMooncakeExt.jl	`96.95% <100.00%> (-2.18%)`	⬇️
src/common/defaults.jl	`64.28% <100.00%> (+2.74%)`	⬆️
src/common/pullbacks.jl	`100.00% <100.00%> (ø)`
src/pullbacks/polar.jl	`100.00% <100.00%> (ø)`
src/pullbacks/eig.jl	`86.20% <88.88%> (+1.14%)`	⬆️
src/pullbacks/eigh.jl	`81.25% <88.88%> (+1.25%)`	⬆️
src/pullbacks/svd.jl	`89.25% <90.90%> (+0.92%)`	⬆️
ext/MatrixAlgebraKitChainRulesCoreExt.jl	`82.14% <85.71%> (+0.32%)`	⬆️
src/pullbacks/lq.jl	`95.89% <88.46%> (+0.57%)`	⬆️
src/pullbacks/qr.jl	`95.89% <88.46%> (+0.65%)`	⬆️
... and 2 more

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kshyatt · 2026-01-20T10:31:28Z

I think this is ready for review if CI passes, it's not testing the Diagonal stuff for now waiting on @lkdvos 's PR, but it will radically simplify adding tests for that and CUDA and Enzyme

lkdvos

I left a bunch of smaller comments through the code, and only quickly went through the actual test suites. Am I correct that these haven't changed much?

I think in general it would be nice to try and link some of the GPU issues we are facing with actual issue numbers and resolve them through dispatch alternatives, rather than having to alter the code for regular arrays as well.
In particular, isa(A, Array) seems a bit to strict since we also support views etc, which would then also take the slow path.

ext/MatrixAlgebraKitCUDAExt/MatrixAlgebraKitCUDAExt.jl

ext/MatrixAlgebraKitMooncakeExt/MatrixAlgebraKitMooncakeExt.jl

src/pullbacks/eig.jl

test/testsuite/ad_utils.jl

test/testsuite/chainrules.jl

src/pullbacks/svd.jl

src/pullbacks/eig.jl

src/pullbacks/polar.jl

kshyatt · 2026-01-23T06:13:28Z

Now that the enzyme stuff is merged, I'll work on incorporating that into this PR and addressing the remaining comments

kshyatt · 2026-01-23T10:51:52Z

OK, the Enzyme tests are now part of the testsuite. I turned off the Diagonal tests for now in the interests of dealing with that in a subsequent PR.

kshyatt · 2026-01-26T14:18:41Z

OK, turned off GPU tests for Enzyme also because of EnzymeAD/Enzyme.jl#2676. I'd rather get this in and incrementally add various things as we go.

test/runtests.jl

lkdvos

Up to the last minor comment about the ad_utils file, I agree this is ready to go. Thanks for the large refactor!

lkdvos · 2026-01-26T18:40:52Z

It looks like the enzyme tests still need some work here

kshyatt · 2026-01-27T11:18:27Z

Something bad is going on with BigFloat but as no one urgently needs this my suggestion is to focus on the BlasFloats for enzyme and return to this when we need it

* update changelog * bump v0.6.4 * add list of contributors * Update Project.toml Co-authored-by: Jutho <Jutho@users.noreply.github.com> --------- Co-authored-by: Jutho <Jutho@users.noreply.github.com>

kshyatt requested review from Jutho and lkdvos December 23, 2025 07:58

kshyatt commented Dec 23, 2025

View reviewed changes

ext/MatrixAlgebraKitCUDAExt/MatrixAlgebraKitCUDAExt.jl Show resolved Hide resolved

kshyatt force-pushed the testsuite-ad branch 2 times, most recently from 0669d08 to 958dd36 Compare December 23, 2025 18:25

kshyatt force-pushed the testsuite-ad branch 6 times, most recently from fad3f4a to daeab4d Compare January 9, 2026 09:52

kshyatt force-pushed the testsuite-ad branch from 2b921df to b6e01ed Compare January 19, 2026 15:03

kshyatt force-pushed the testsuite-ad branch from b6e01ed to 6ffb2af Compare January 20, 2026 10:01

kshyatt force-pushed the testsuite-ad branch from 6ffb2af to 239686e Compare January 20, 2026 18:33

lkdvos reviewed Jan 20, 2026

View reviewed changes

lkdvos reviewed Jan 21, 2026

View reviewed changes

src/pullbacks/svd.jl Outdated Show resolved Hide resolved

lkdvos reviewed Jan 22, 2026

View reviewed changes

src/pullbacks/eig.jl Outdated Show resolved Hide resolved

src/pullbacks/eig.jl Outdated Show resolved Hide resolved

lkdvos reviewed Jan 22, 2026

View reviewed changes

src/pullbacks/polar.jl Outdated Show resolved Hide resolved

kshyatt force-pushed the testsuite-ad branch from da5f1bb to 2348b5e Compare January 23, 2026 10:51

kshyatt force-pushed the testsuite-ad branch from 641cd20 to d9a2945 Compare January 23, 2026 10:59

kshyatt force-pushed the testsuite-ad branch from a9412e5 to fe0e6e9 Compare January 26, 2026 14:18

lkdvos reviewed Jan 26, 2026

View reviewed changes

test/runtests.jl Show resolved Hide resolved

lkdvos reviewed Jan 26, 2026

View reviewed changes

test/runtests.jl Outdated Show resolved Hide resolved

lkdvos approved these changes Jan 26, 2026

View reviewed changes

kshyatt enabled auto-merge (squash) January 26, 2026 16:18

lkdvos disabled auto-merge January 26, 2026 18:40

kshyatt and others added 17 commits January 28, 2026 08:42

Use Testsuite for AD tests

fbfb889

Get rid of custom GPU tolerances

c5db5b5

Fixes for enzyme

c12f558

Fix some remaining typos and turn off GPU

e18caf6

Fix runtests

628efdb

Turn off GPU for Mooncake too

90f5ce1

Remove deletion of nonexistent file

f5be465

More Enzyme fix

08e0cfb

More bad variables

a84f8c7

More missing stuff

1fcc8b2

Yet another stupid typo

e1bc266

ANOTHER ONE

864b8b7

Fix other typos

e4503b2

Turn off BigFloats for now

e0705e1

Format

9d1e0ff

No windows

a11f506

Two types is too expensive

9f86477

kshyatt force-pushed the testsuite-ad branch from ae21b1a to 9f86477 Compare January 28, 2026 07:42

Don't run AD tests on macOS CI at all

4476498

kshyatt enabled auto-merge (squash) January 28, 2026 09:12

kshyatt merged commit b900e8a into main Jan 28, 2026
10 checks passed

kshyatt deleted the testsuite-ad branch January 28, 2026 09:21

lkdvos mentioned this pull request Jan 29, 2026

v0.6.4 #165

Merged

lkdvos referenced this pull request Jan 30, 2026

v0.6.4 (#165)

8de569f

* update changelog * bump v0.6.4 * add list of contributors * Update Project.toml Co-authored-by: Jutho <Jutho@users.noreply.github.com> --------- Co-authored-by: Jutho <Jutho@users.noreply.github.com>

Conversation

kshyatt commented Dec 23, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kshyatt commented Jan 20, 2026

Uh oh!

lkdvos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kshyatt commented Jan 23, 2026

Uh oh!

kshyatt commented Jan 23, 2026

Uh oh!

kshyatt commented Jan 26, 2026

Uh oh!

Uh oh!

Uh oh!

lkdvos left a comment

Choose a reason for hiding this comment

Uh oh!

lkdvos commented Jan 26, 2026

Uh oh!

kshyatt commented Jan 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Dec 23, 2025 •

edited

Loading

codecov bot commented Jan 19, 2026 •

edited

Loading