Refactor of IDMRG with IterativeSolver#348
Merged
lkdvos merged 7 commits intoQuantumKitHub:mainfrom Dec 2, 2025
Merged
Conversation
…ing code between IDMRG and IDMRG2
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 17 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
reviewed
Dec 1, 2025
Contributor
Author
|
@lkdvos: I have implemented the points we discussed today. it.state = IDMRGState(mps, state.operator, envs, state.iter + 1, ϵ, T(E_new))I am not sure, which way I prefer. |
Contributor
Author
|
PS: The one-line change in |
lkdvos
reviewed
Dec 2, 2025
Member
lkdvos
left a comment
There was a problem hiding this comment.
Overall looks great, thank you!
lkdvos
reviewed
Dec 2, 2025
lkdvos
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I refactor
IDMRGto follow theIterativeSolverinterface (asVUMPS).This allows to share more code between
IDMRGandIDMRG2and also simplifies overloading some parts of the algorithm for e.g. differentMPOtypes.