-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ase from 3.23.0 to 3.24.0 #2384
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2384 +/- ##
==========================================
+ Coverage 97.33% 97.36% +0.02%
==========================================
Files 85 85
Lines 3566 3566
==========================================
+ Hits 3471 3472 +1
+ Misses 95 94 -1 ☔ View full report in Codecov by Sentry. |
@tomdemeyere: FYI that something seems broken with the Espresso output reader and the dev version of ASE as noted here. I'm not quite sure what yet. But just keeping you in the loop. |
This is ASE related. A recent PR (https://gitlab.com/ase/ase/-/merge_requests/3527) changed how the reader is supposed to read lattice parameters ( I will think on how to fix it |
Turning the one failing test to skip since it's an upstream ASE issue and I need to support ASE 3.24.0 more broadly. |
No description provided.