-
Notifications
You must be signed in to change notification settings - Fork 11
refactor!: Rename tk2 encoder names to tket #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like there are some merge conflicts. |
|
Forgot to change the base back to |
cqc-alec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with renaming "tk2" things to "tket". Not so sure about renaming "tk1" things to "pytket" and "legacy".
- It's not clear why it's sometimes one and sometimes the other.
- It leads to some funny names, like
PyPytketEncodeError. - It emphasizes a difference of language, which is not really the point.
- Maybe it is a bit early to be calling old-tket "legacy".
Would it be so bad to keep using "tk1" as code for old-tket?
|
Fair enough. I removed most changes, but left the main ones I wanted;
|
9608829 to
b83f74c
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
=======================================
Coverage 79.74% 79.74%
=======================================
Files 97 97
Lines 11674 11674
Branches 11395 11395
=======================================
Hits 9309 9309
Misses 1734 1734
Partials 631 631
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
b83f74c to
fc8bc29
Compare
## 🤖 New release * `tket`: 0.13.2 -> 0.14.0 (✓ API compatible changes) * `tket-qsystem`: 0.18.1 -> 0.19.0 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `tket` <blockquote> ## [0.14.0](tket-v0.13.2...tket-v0.14.0) - 2025-08-18 ### New Features - [**breaking**] Allow PytketTypeTranslators to translate nested types ([#1038](#1038)) - Define a wire tracker for the new pytket decoder ([#1036](#1036)) - [**breaking**] Reworked pytket decoder framework ([#1030](#1030)) - [**breaking**] Use qsystem encoder/decoders in tket-py ([#1041](#1041)) - [**breaking**] Avoid eagerly cloning SerialCircuits when decoding from pytket ([#1048](#1048)) ### Refactor - [**breaking**] Rename tk2 encoder names to tket ([#1037](#1037)) </blockquote> ## `tket-qsystem` <blockquote> ## [0.19.0](tket-qsystem-v0.18.1...tket-qsystem-v0.19.0) - 2025-08-18 ### New Features - Add emitters for tket-qsystem ([#1039](#1039)) - [**breaking**] Avoid eagerly cloning SerialCircuits when decoding from pytket ([#1048](#1048)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
No functionality changes, only renames that we didn't do in #987
I'm not touching the decoder code, since it's already being modified by #1030
BREAKING CHANGE: Renamed various pytket encoder-related structs and methods from
tk1*topytketBEGIN_COMMIT_OVERRIDE
chore: Rename tk2 encoder names to tket (#1037)
END_COMMIT_OVERRIDE