Repository navigation
feat!: Add support for LogicalBlock in verifier - #199
Merged
Merged
Conversation
CalMacCQ
previously approved these changes
Aug 11, 2026
CalMacCQ
left a comment
CalMacCQ
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks Henry. Just one question that I think is inconsequential really.
CalMacCQ
reviewed
Aug 11, 2026
hsemenenko
marked this pull request as draft
August 11, 2026 11:02
hsemenenko
dismissed
CalMacCQ’s stale review
August 11, 2026 11:03
This has highlighted a big issue with using Iterable in the unitary verification which need more thought on how to address.
Collaborator
Author
|
For the unitary tests, the Bell state is prepared as an array. This is incompatible with having an implementation function that expects |
hsemenenko
changed the title
Iterable protocol for compatibility with LogicalBlock typeLogicalBlock in verifier
|
This PR contains breaking changes to the public Python API. Breaking changes summary |
CalMacCQ
approved these changes
Oct 19, 2026
CalMacCQ
left a comment
CalMacCQ
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Thanks @hsemenenko
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds overloads to the verifier to support
LogicalBlocktypes. This also cleans up the types and function signatures.BREAKING CHANGE: Remove
LogicalBlock.put_into_arraymethod