-
Notifications
You must be signed in to change notification settings - Fork 10
feat: Allow semantic comparison of collections #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 41 41
Lines 2148 2207 +59
=========================================
+ Hits 2148 2207 +59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a few comments on implementational details :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you! Just two comments left 😄
Co-authored-by: Oliver Borchert <oliver.borchert@quantco.com>
Motivation
Same as #55 but for
Collection
s instead ofSchema
s. Preparation for serialization ofCollection
definitions.Changes
Collection.matches
, which semantically compares the present collection with another one and returns a boolean indicating whether the two Collections are equivalent,.