feat: Recover from reading incompatible schema metadata if validation is allowed #231
+262
−47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serialization formats change (e.g.,
primary_keysvsprimary_key), previously serialized schemas/collections become unreadable. Schema deserialization already handles this via astrictparameter, but collections did not. Additionally, when reading serialized data, using non-strict schema deserialization in all cases that would allow validation to be run allows to recover from unreadable metadata where it is not needed.Changes
strictparameter todeserialize_collection: Mirrors existingdeserialize_schemabehavior—whenstrict=False, returnsNoneon deserialization errors instead of raising exceptionsstrictthrough deserialization chain: Updated_deserialize_typesto accept and forward the parameterscan_parquet/read_parquetvalidation modes: BothCollection._readandSchema._validate_if_needednow passstrict=Falsewhenvalidationis "allow", "skip" or "warn", allowing automatic fallback to validation when old formats are detectedOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.