Skip to content

refactor: Move IO specifics out of Schema, Collection #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

AndreasAlbertQC
Copy link
Collaborator

@AndreasAlbertQC AndreasAlbertQC commented Aug 6, 2025

Motivation

The current implementation of parquet-based storage is strongly coupled to the implementation of the Schema and Collection classes. This makes it hard to reuse parts of the logic that would also be useful for other future storage backends. To prepare the implementation of such future storage backends, this PR refactors the current logic to introduce a clearer interface for storage backends.

Changes

  • Introduced the notion of a StorageBackend, i.e. a piece of code encapsulating a way of storing data and metadata.
  • Refactored the parquet storage logic to use the StorageBackend interface

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.88%. Comparing base (fbf08c8) to head (292a8b6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #109      +/-   ##
===========================================
- Coverage   100.00%   99.88%   -0.12%     
===========================================
  Files           42       42              
  Lines         2443     2525      +82     
===========================================
+ Hits          2443     2522      +79     
- Misses           0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AndreasAlbertQC AndreasAlbertQC marked this pull request as ready for review August 8, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants