Skip to content

Conversation

@jstac
Copy link
Contributor

@jstac jstac commented Nov 14, 2025

Summary

This PR makes small improvements to the mccall_model_with_sep_markov lecture for better code clarity and readability.

Changes

  • Renamed variables in the T function for clarity:

    • acceptv_e (employment value function)
    • rejecth (continuation value)
  • Renamed variables in the get_reservation_wage function:

    • acceptv_e (employment value function)
    • rejectcontinuation_values (continuation value, plural since it's an array)
    • should_acceptaccept_indices (boolean array indicating which wages to accept)
    • Added clarifying comment: "# index of first True"

These changes improve code readability by using more descriptive variable names that better reflect their mathematical meaning in the model.

jstac and others added 2 commits November 14, 2025 13:36
Resolve merge conflicts in mccall_model_with_sep_markov.md by combining
variable naming improvements from both branches:
- Use 'v_e' and 'continuation_values' for clarity (plural since it's an array)
- Use 'accept_indices' for the boolean array
- Keep improved comments from both versions

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions
Copy link

📖 Netlify Preview Ready!

Preview URL: https://pr-703--sunny-cactus-210e3e.netlify.app (a6625f0)

📚 Changed Lecture Pages: mccall_model_with_sep_markov

@jstac jstac merged commit 60a9857 into main Nov 14, 2025
1 check passed
@jstac jstac deleted the mmsm_a branch November 14, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants