-
-
Notifications
You must be signed in to change notification settings - Fork 54
[mle] Update lecture with latest code and style #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mmcky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kp992 I have left some minor suggestions and a question re: use of in-built methods.
HumphreyYang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Deploy Preview for sunny-cactus-210e3e ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Many thanks @kp992 , this looks great. So nice to see autodiff at work! @kp992 @mmcky @HumphreyYang We should try hard to stick to 80 characters per line so that the code fits neatly on the page in html and pdf. It would be good to catch this in PRs when possible. |
I use jupyter_black auto-formatter while updating the notebook. We just need to add the code block in the start: I see that by default it uses 88 chars but we can change that to 80: |
|
Thanks @kp992 ! |
|
thanks @kp992, @jstac and @HumphreyYang. LGTM. |
Updates the
mlelecture: