Skip to content

Conversation

@kp992
Copy link
Contributor

@kp992 kp992 commented Aug 26, 2025

Updates the mle lecture:

  • Removed all the old code and replaced with JAX.
  • Removed numpy dependency completely.
  • Fixed some typos.

@github-actions
Copy link

github-actions bot commented Aug 28, 2025

@github-actions github-actions bot temporarily deployed to pull request August 28, 2025 00:35 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 28, 2025 00:36 Inactive
@kp992 kp992 requested a review from mmcky August 29, 2025 01:11
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kp992 I have left some minor suggestions and a question re: use of in-built methods.

@mmcky mmcky added the review label Aug 31, 2025
@github-actions github-actions bot temporarily deployed to pull request August 31, 2025 22:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 31, 2025 22:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 2, 2025 03:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 2, 2025 03:19 Inactive
Copy link
Member

@HumphreyYang HumphreyYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @kp992! Other than @mmcky's comment, this looks good to me!

@github-actions github-actions bot temporarily deployed to pull request September 3, 2025 23:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 3, 2025 23:45 Inactive
@mmcky
Copy link
Contributor

mmcky commented Sep 5, 2025

thanks @kp992 I see my comment is now resolved in 511f044

@mmcky mmcky requested a review from jstac September 5, 2025 01:31
@netlify
Copy link

netlify bot commented Sep 9, 2025

Deploy Preview for sunny-cactus-210e3e ready!

Name Link
🔨 Latest commit 026048e
🔍 Latest deploy log https://app.netlify.com/projects/sunny-cactus-210e3e/deploys/68bfb2106f55a4000857f249
😎 Deploy Preview https://deploy-preview-572--sunny-cactus-210e3e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

@github-actions github-actions bot temporarily deployed to pull request September 9, 2025 03:51 Inactive
@mmcky

This comment was marked as duplicate.

@jstac
Copy link
Contributor

jstac commented Sep 9, 2025

Many thanks @kp992 , this looks great. So nice to see autodiff at work!

@kp992 @mmcky @HumphreyYang We should try hard to stick to 80 characters per line so that the code fits neatly on the page in html and pdf. It would be good to catch this in PRs when possible.

@kp992
Copy link
Contributor Author

kp992 commented Sep 9, 2025

We should try hard to stick to 80 characters per line so that the code fits neatly on the page in html and pdf

I use jupyter_black auto-formatter while updating the notebook. We just need to add the code block in the start:

import jupyter_black
jupyter_black.load()

I see that by default it uses 88 chars but we can change that to 80:

jupyter_black.load(line_length=80)

@github-actions github-actions bot temporarily deployed to pull request September 9, 2025 05:03 Inactive
@jstac
Copy link
Contributor

jstac commented Sep 9, 2025

Thanks @kp992 !

@mmcky
Copy link
Contributor

mmcky commented Sep 10, 2025

thanks @kp992, @jstac and @HumphreyYang. LGTM.

@mmcky mmcky merged commit d695a10 into main Sep 10, 2025
6 checks passed
@mmcky mmcky deleted the mle_fixes branch September 10, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants