-
-
Notifications
You must be signed in to change notification settings - Fork 54
[two_auction] Lecture review with math and warning fixes #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @mmcky, this PR fixes the python warning mentioned in #548. There are a few lectures using JAX that has cache build failure as shown in the statistics that is related to the CuDNN version of the builder. For instance, Please let me know your thoughts when you have time! EDIT: False Alarm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes warnings, improves code formatting, and corrects mathematical expressions and typos in the two auctions lecture. The changes focus on bringing the code up to PEP8 standards while fixing several content issues.
Key changes:
- Fixed mathematical error in surplus value calculation (line 77)
- Corrected spelling errors including "Wikepedia" to "Wikipedia" and "randomess" to "randomness"
- Reformatted code to follow PEP8 standards with proper spacing and line breaks
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
@HumphreyYang thanks for this PR. I'm not seeing the issue you mention re: CUDANN in: is that the correct place to be looking? In the preview? |
Thanks @mmcky, my bad, it's a false alarm. I was looking at the build on my end and confused it with the preview. My CuDNN needs an upgrade : ) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
thanks @HumphreyYang for the PR. LGTM. |
This PR: