Skip to content

Conversation

@shlff
Copy link
Member

@shlff shlff commented Oct 9, 2020

Hi @mmcky , this PR converts exercises and solutions of lecture functions using sphinx-exercise's syntax.

I noticed two weird things in the following preview:

  • for Exercise part, the name for exercises are Exercise 4.1, Exercise 4.2, Exercise 4.3, instead of Exercise 1, Exercise 2, Exercise 3.
  • for Solution part, it fails to execute all python cells!

For the issue in exercise numbering, I tried to use nonumber option. It just shuts down the whole numbering for exercises, but I don't find a way to change the names of exercises.

@mmcky mmcky changed the title [functions]Migrating exercise to use sphinx-exercise [functions] Mograte exercise to use sphinx-exercise Oct 12, 2020
@mmcky mmcky changed the title [functions] Mograte exercise to use sphinx-exercise [functions] Migrate exercise to use sphinx-exercise Oct 12, 2020
@mmcky mmcky added the on-hold label Oct 22, 2020
@mmcky
Copy link
Contributor

mmcky commented Sep 20, 2021

We are doing a major refactor of sphinx-exercise so once that is done we can use this as a test case.

@github-actions github-actions bot temporarily deployed to commit October 18, 2021 05:27 Inactive
@github-actions github-actions bot temporarily deployed to commit October 25, 2021 06:41 Inactive
@github-actions github-actions bot temporarily deployed to commit October 25, 2021 06:49 Inactive
@mmcky mmcky removed the on-hold label Oct 25, 2021
@github-actions github-actions bot temporarily deployed to commit October 25, 2021 07:03 Inactive
@mmcky
Copy link
Contributor

mmcky commented Oct 25, 2021

@jstac I think we could enable sphinx-exercise for the lectures more generally now that latex is supported.

While code-cell isn't directly enabled what do you think about this approach for the interim:

https://617656cde2d4e2288538c01a--epic-agnesi-957267.netlify.app/functions.html#solutions

I think it looks OK with code-cells following the solution block (so that it executes).

@jstac
Copy link
Contributor

jstac commented Oct 25, 2021

I think it's very sensible :-)

I wonder how we can get this done though. We are short on RA money. Any thoughts?

Do we have Sloan money we can spend?

@mmcky
Copy link
Contributor

mmcky commented Nov 23, 2021

@jstac there is a great case in writing_good_code that shows we really need the gated directives (ideally). It has a lot of code-cell directives mixed in with text and hard to make it look cohesive in the above approach.

We could either:

  • migrate the lectures that contain straight forward cases as this is the majority of cases
  • put this on hold until we have gated directives (~1-2 months)

@github-actions github-actions bot temporarily deployed to commit March 8, 2022 03:51 Inactive
@github-actions github-actions bot temporarily deployed to commit March 8, 2022 04:05 Inactive
@github-actions github-actions bot temporarily deployed to commit March 8, 2022 04:31 Inactive
@github-actions github-actions bot temporarily deployed to commit March 8, 2022 04:50 Inactive
@github-actions github-actions bot temporarily deployed to commit March 8, 2022 04:58 Inactive
@mmcky
Copy link
Contributor

mmcky commented Mar 8, 2022

Closing in favour of #176

@mmcky mmcky closed this Mar 8, 2022
@mmcky mmcky deleted the func branch March 8, 2022 05:09
@github-actions github-actions bot temporarily deployed to commit March 8, 2022 05:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants