-
-
Notifications
You must be signed in to change notification settings - Fork 25
Review lectures #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review lectures #255
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks @DiaPorntipa for creating the PR, but there's still some changes I need to commit before merging. |
Thanks @DiaPorntipa ! Very helpful. Please see the small requests above. |
Hi @jstac, I've applied the review changes and make other modifications. |
Thanks @HengchengZhang , nice work. I think this code block should be hidden: # transfer the survey weights from absolute into relative values
... And in the code block below it, we should stick to PEP8 --- in particular, lines should be 80 characters max, so those long function calls need to be spread across two lines. |
Hi @jstac, I see that's because there's error in codes and now they are fixed. Similar errors are in LA lecture as well and I will fix it next reading group. |
Thanks @HengchengZhang for the update. |
Nice work @DiaPorntipa and @HengchengZhang . Merging. |
Hello @jstac, this PR contains all minor changes of lectures 3 and 4 edited by @HengchengZhang , @orectique and me.