-
-
Notifications
You must be signed in to change notification settings - Fork 26
ENH: Set a default image size across all lectures #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @mmcky, I've removed the width settings in |
@HengchengZhang if you could do a sweep of all the lectures in this repo that would be great 👍 |
Thanks @mmcky, for the figures that are set with
|
|
Some of this will need some experimenting. Thanks @HengchengZhang for investigating further.
Does the
This is a good idea. Can you review the
👍 |
|
Hi @mmcky,
The results are quite intersting
Modify the global settings in works well in my local environment. If that looks good to you I will apply this change and see if this works for all lectures in this repo(when removing the width settings). |
|
A note to myself @HengchengZhang
|
|
Hi @mmcky, when I'm lokking into lecture-python-intro/lectures/long_run_growth.md Lines 133 to 136 in a0fa02f
I’m wondering is there a specific reason for this dpi = 110 and not other higher number? Because I think 110 is not quite a high resolution overall and I’m not sure if there is a trade-in with the performance or something else.
Another way to make the figure looks better is to make it wider like |
@HengchengZhang it was to increase the quality from the |
|
nice work on this so far @HengchengZhang. @jstac the deployment shows what we have currently set the image size too. I am wondering if we should go up to 80% or even 85%. Such as across this lecture: https://6440ec408ea47d5c6a90e4cb--taupe-gaufre-c4e660.netlify.app/business_cycle.html Also do you like the shadow? It is really nice having the same sized image. |
|
thanks @HengchengZhang this is looking great. @jstac let's merge this soon -- given the impact on a number of lectures. |
|
Great work @HengchengZhang !! So nice to have your help getting this in order :-) I agree we could come up to Please merge when ready. |
|
Actually guys, I wonder what the best order is for merging. Let me discuss this with @mmcky . I'll just do a spin through the other PRs. |
|
thanks @jstac we merged the others and will fix the merge conflict in this PR. Thanks @HengchengZhang |
|
@HengchengZhang did you get a chance to review these merge conflicts? |
|
Hi @mmcky, sorry about the delay. I've fixed the conflicts and should be able to merge now. |
|
no worries @HengchengZhang thanks for your work on this. |
This PR sets a default image size to 75% of page width throughout the lectures for
codegenerated figures.inequalitylecturesound be
@HengchengZhang would you be able to run some searches and remove the width setting (unless you think it is sized specifically for some other reason). We are trying to standardise image sizes across the lecture for consistency with this global setting.