Skip to content

Add interpolation methods #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

najuzilu
Copy link

@najuzilu najuzilu commented May 11, 2020

This PR adds interpolation methods provided by @jstac in order to replace our lectures' dependency on the interpolation package. This solution was suggested here.

The methods can be found under the interpolation directory. I have removed the test method as tests will need to be implemented under a test directory.

The following need to be implemented:

  • test cases

Feedback would be greatly appreciated.

@pep8speaks
Copy link

pep8speaks commented May 11, 2020

Hello @najuzilu! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 6:80: E501 line too long (87 > 79 characters)

Comment last updated at 2020-05-11 07:19:52 UTC

@mmcky mmcky added the in-work label May 15, 2020
@mmcky
Copy link
Contributor

mmcky commented May 15, 2020

The interpolations package was updated to cater to earlier version of numba so this should only go ahead if we would like to support some interpolation routines.

Thanks for putting this together @najuzilu but let's put this on hold given there is a nice solution already out there that we can use.

@mmcky
Copy link
Contributor

mmcky commented Apr 5, 2022

@jstac I think in general -- the interpolation routines in the interpolations package will reduce our maintenance burden. Are you happy to keep using those or do we want to revive this PR?

@jstac
Copy link
Contributor

jstac commented Apr 5, 2022

Agree, thanks @mmcky , closing.

@jstac jstac closed this Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants