-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Remove code that supported optional numba installation #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In #246 It was resolved to remove the python2.7 range statements and to keep the |
I will leave this open for a day - in case there are any comments on the final diff. |
#-Check if Numba is Available-# | ||
from .util import numba_installed, jit | ||
|
||
#TODO: Should this be specified with (nopython=True?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jit(nopython=True)
will work if the line A = np.asarray(A)
is removed (assuming that the input A
is an numpy ndarray). (But I suspect we wouldn't get much speedup.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @oyamad Agree. Let's leave this as is.
Thanks for your comments @oyamad. I will now remove the |
This PR removes code that was written to support environments that did't have
numba
installed. Now thatnumba
is a strict dependency of the package - this code can now be removed. This will simplify how code is written etc.Updates:
markov/gth_solve
should we remove the following given support for Python 3.5+:gth_solve
so as not to change the code to much, I have added ause_jit
header to the function signature to allow one to optionally use numpy. @oyamad Is this ok?Deprecations:
numba_installed
package wide variable is no longer available.