Skip to content

Fix optgrowth solution notebook #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2015
Merged

Fix optgrowth solution notebook #188

merged 4 commits into from
Nov 6, 2015

Conversation

oyamad
Copy link
Member

@oyamad oyamad commented Sep 16, 2015

Due to the change #41 in the behavior of compute_fixed_point, the solution notebook for Exercise 1 in the lecture on Infinite Horizon Dynamic Programming has to be revised.

  • In compute_fixed_point(gm.bellman_operator, w, max_iter=n), w is now modified in-place, so the initial condition w = 5 * gm.u(gm.grid) - 25 has to be set inside the for loop.
  • I suspect the figures in the lecture have to be fixed as well.
  • In the notebook I executed, the Figure for Exercise 2 looks different from the one in the previous notebook or in the lecture.
  • optgrowth_solutions.ipynb

@mmcky
Copy link
Contributor

mmcky commented Nov 6, 2015

@oyamad Thanks for this. I see - because w is updated in place it now needs to be reset in each iteration. Will merge and update the figures in the lectures.

@mmcky mmcky closed this Nov 6, 2015
@mmcky mmcky reopened this Nov 6, 2015
mmcky added a commit that referenced this pull request Nov 6, 2015
@mmcky mmcky merged commit 09fa2ca into master Nov 6, 2015
@mmcky mmcky deleted the solution-optgrowth branch November 6, 2015 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants