-
Notifications
You must be signed in to change notification settings - Fork 2
Important Issues #23
Description
Hi, I have tried this extension and found this very useful. Though this has some issues -
Polling for shutdown kernel
If the extension is opened in the right pane and if the kernel whose info is currently being shown is shut, the extension still polls for that, and all requests give 404 kernel not found error -
No. of requests being sent on notebook tab change
The extension makes nearly exponential no. of API calls in some cases which can eventually crash the server or give too many file descriptors error. Steps to reproduce -
- Open two notebooks and the extension in the right pane
- Open the networks tab as well
- Switch between notebook tabs and notice the no. of requests being sent each time and how fast they grow in number
This can also be confirmed by adding a console log statement around this line.
Requests go into the pending state when the kernel is busy
The extension makes API calls to get the kernel info. If there is a long-running cell say -
while True:
x=1
all the requests go into the pending state. Likely it gets stuck at this line. After this, all other core jupyterlab requests go into pending state e.g. /sessions, /terminals etc.
UX (Minor)
Assuming the extension is opened in the right pane. When multiple notebooks are opened and they are tab-switched, the kernel id and notebook name shown in the UI are updated very quickly, but other memory metrics corresponding to this kernel take time to show up, during this period it shows metrics of the last active notebook, which can give a false impression. A solution here would be to show a loading status?