Move CSV writer extensions to JVM-only to resolve os-lib dependency warning #124
+14
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Quafadas <24899792+Quafadas@users.noreply.github.com>
Co-authored-by: Quafadas <24899792+Quafadas@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix OS lib warnings in JavaScript
Move CSV writer extensions to JVM-only to resolve os-lib dependency warning
Jan 28, 2026
Quafadas
added a commit
that referenced
this pull request
Jan 28, 2026
* fix os lib on JS warning * . * fmty * . * Move CSV writer extensions to JVM-only to resolve os-lib dependency warning (#124) * Initial plan * Move CSV writer extensions to JVM-only to fix os-lib warning on JS Co-authored-by: Quafadas <24899792+Quafadas@users.noreply.github.com> * Fix documentation and naming inconsistency in csvWriterExtensions Co-authored-by: Quafadas <24899792+Quafadas@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Quafadas <24899792+Quafadas@users.noreply.github.com> * [autofix.ci] apply automated fixes --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Quafadas <24899792+Quafadas@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSVWriterExtensionswas using os-lib file I/O APIs (os.Path,os.temp,os.write) in shared source, causing warnings on the JS platform where os-lib is unavailable.Changes:
csvWriterExtensions.scalaandcsvWriterTest.scalato JVM-specific directories (src-jvm/,test/src-jvm/)src-js/csvWriterExtensions.scalafor API compatibility (follows existingStatspattern)csvWriter.scalain shared source (no os-lib dependencies)API Impact:
Cross-platform methods remain available on both JVM and JS:
toCsv()- converts to iterator of CSV linestoCsvString()- converts to CSV stringJVM-only methods that write to disk:
writeCsv()- writes to file with os-libwriteCsvIterator()- writes iterator to file with os-lib✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.