refactor: replace direct hasOwnProperty calls#9
Open
deepsource-autofix[bot] wants to merge 1 commit into
Open
Conversation
This PR refactors the code to avoid calling built-in methods directly on objects. Each instance of `obj.hasOwnProperty(key)` has been replaced with `Object.prototype.hasOwnProperty.call(obj, key)` to ensure a safe, reliable property check regardless of an object’s prototype state. - Object.prototype builtins should not be used directly: The existing code invoked `hasOwnProperty` directly on objects like `headers` and `expectedHeaders`, which can lead to incorrect behavior if those objects have a null prototype or an overridden method. We updated all three occurrences to use `Object.prototype.hasOwnProperty.call(obj, key)`, safeguarding against prototype pollution and ensuring consistent behavior. > This Autofix was generated by AI. Please review the change before merging.
|
Here's the code health analysis summary for commits Analysis Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the code to avoid calling built-in methods directly on objects. Each instance of
obj.hasOwnProperty(key)has been replaced withObject.prototype.hasOwnProperty.call(obj, key)to ensure a safe, reliable property check regardless of an object’s prototype state.hasOwnPropertydirectly on objects likeheadersandexpectedHeaders, which can lead to incorrect behavior if those objects have a null prototype or an overridden method. We updated all three occurrences to useObject.prototype.hasOwnProperty.call(obj, key), safeguarding against prototype pollution and ensuring consistent behavior.