Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised index.md #952

Merged
merged 3 commits into from
May 22, 2024
Merged

Revised index.md #952

merged 3 commits into from
May 22, 2024

Conversation

johnzl-777
Copy link
Collaborator

After some meetings with @Roger-luo on improving the documentation this is what I came up with for the new index.md page.

@johnzl-777 johnzl-777 requested a review from Roger-luo May 21, 2024 15:09
@johnzl-777 johnzl-777 marked this pull request as draft May 21, 2024 15:10
Copy link
Contributor

github-actions bot commented May 21, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-22 16:20 UTC

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.76%. Comparing base (5b2b03e) to head (a73579d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #952   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files         110      110           
  Lines        8030     8030           
=======================================
  Hits         7208     7208           
  Misses        822      822           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Roger-luo
Copy link
Member

I just for the record I want to let Phil and Pedro take a look after we finish the quick start and background. Passing this PR mainly to allow following PRs.

@johnzl-777 johnzl-777 marked this pull request as ready for review May 22, 2024 12:49
@Roger-luo
Copy link
Member

please feel free to merge it if you have no further edits.

@johnzl-777 johnzl-777 merged commit 61ffe80 into main May 22, 2024
10 checks passed
@johnzl-777 johnzl-777 deleted the john/revise-index-md branch May 22, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants