Rounding errors when using Record node.
#602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sues with rounding.
|
Codecov Report
@@ Coverage Diff @@
## main #602 +/- ##
=======================================
Coverage 82.84% 82.84%
=======================================
Files 88 88
Lines 7267 7267
=======================================
Hits 6020 6020
Misses 1247 1247
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fixing up the assignments with the
Recordnode in the AST, the original implementation used thefloatversion of the waveform eval which causes rounding errors when trying to generate schemas. switching to evaluating waveform usingDecimalto fix this issue.