feat(variables): add variables tabs at environment scope #2367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
…nd update UI components
TheoGrandin74
changed the title
Contributor
|
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 |
RemiBonnet
requested changes
Feb 12, 2026
Member
RemiBonnet
left a comment
RemiBonnet
left a comment
There was a problem hiding this comment.
Well done @TheoGrandin74 !
I added few small comments for structure and testing
| import { type APIVariableScopeEnum } from 'qovery-typescript-axios' | ||
| import { type UseFormSetValue } from 'react-hook-form' | ||
|
|
||
| export function changeScopeForAll( |
Member
There was a problem hiding this comment.
The extension of the file should be .ts and not .tsx
Could you add a unit test for it? (small one)
| @@ -0,0 +1,13 @@ | |||
| export function deleteEntry( | |||
| @@ -0,0 +1,24 @@ | |||
| import { APIVariableScopeEnum } from 'qovery-typescript-axios' | |||
|
|
|||
| export function jsonToForm( | |||
| @@ -0,0 +1,16 @@ | |||
| import { type APIVariableScopeEnum, type VariableImportRequestVarsInner } from 'qovery-typescript-axios' | |||
|
|
|||
| export function formatData(data: { [key: string]: string }, keys: string[]) { | |||
| @@ -0,0 +1,15 @@ | |||
| export function onDrop(acceptedFiles: File[], handleData: (data: string) => void) { | |||
| @@ -0,0 +1,11 @@ | |||
| import { type UseFormSetValue } from 'react-hook-form' | |||
|
|
|||
| export function triggerToggleAll( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added variables page at environment scope + various design improvments for all variables pages, namely:
Issue:
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release