Fix skipping of slow tests #13119
Merged
Fix skipping of slow tests #13119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
the
stable backport potential
|
One or more of the following people are relevant to this code:
|
mtreinish
approved these changes
Sep 10, 2024
mtreinish
added
type: qa
Pull Request Test Coverage Report for Build 10792560171Details
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
(cherry picked from commit d14eb9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tests with the
@slow_testdecorators should only be run on-demand, but currently are executed in every CI run. We likely didn't notice this since there is only a single slow test at the moment.Details and comments
It looks like a tiny logic bug, missing a
not🙂 If necessary, we could maybe add a test setting the environment variableQISKIT_TEST, but it seems straightforward enough as fix and works as expected locally.No reno as this is not user facing.