Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Single and multi-qubit SWAP test tutorial #1205

Closed
wants to merge 8 commits into from

Conversation

darshkaushik
Copy link

@darshkaushik darshkaushik commented Jun 26, 2021

Summary

This is a tutorial on SWAP test that might help users to understand how the SWAP test works and how it could be generalized to N-qubits

Details and comments

This is to fix #1228

@CLAassistant
Copy link

CLAassistant commented Jun 26, 2021

CLA assistant check
All committers have signed the CLA.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@darshkaushik darshkaushik marked this pull request as ready for review July 8, 2021 00:27
@darshkaushik darshkaushik mentioned this pull request Jul 8, 2021
@darshkaushik
Copy link
Author

@woodsp-ibm can you please help out here

@woodsp-ibm
Copy link
Member

If I look in the error log from the build it has this

Notebook error:
NoSuchKernel in tutorials/algorithms/09_swap_test.ipynb:
No such kernel named qiskitml

But I see now from your issue you already have seen that. It relates to this in the notebook at the end from the kernel setting

  "kernelspec": {
   "display_name": "qiskitml",
   "language": "python",
   "name": "qiskitml"
  },

If you look at other notebooks here (view Raw) they look like

  "kernelspec": {
   "display_name": "Python 3",
   "language": "python",
   "name": "python3"
  },

So if you can switch the kernel to python3 which I think is the default, then it should run here too I think

Now the algorithms folder here is intended as a learning path for the code in qiskit.algorithms. I know @nonhermitian created a new category textbook that is more geared towards say textbook algorithms etc - maybe this is better placed there.

@darshkaushik
Copy link
Author

@woodsp-ibm it worked, thanks a ton. @nonhermitian I have added a copy of this tutorial in textbook section too as suggested.

Hoping to get a review.

@darshkaushik
Copy link
Author

darshkaushik commented Jul 12, 2021

@nonhermitian @woodsp-ibm can you give this a review

@Eric-Arellano
Copy link
Collaborator

Hi, pardon that this never got a final review :/ Thank you for making Qiskit better!

We're very soon archiving the qiskit-tutorials repository to simplify how we build our documentation. The tutorials will be built directly in https://github.com/Qiskit/qiskit-terra and algorithms related ones in https://github.com/qiskit-community/qiskit-algorithms.

If you'd still be interested in landing this, it'd be best to open up a new PR in qiskit-algorithms. They're setting up the tutorial infrastructure this week.

I unfortunately can't comment on whether the PR would be accepted or not because I don't know the underlying content well enough. But the repo is more actively maintained so should get a response, and I can help ping the relevant people if you haven't heard back.

Again, sorry for us not reviewing this earlier!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

SWAP test tutorial
4 participants