Raise warning if instance limit is reached #2458
Conversation
kt474
added
the
Changelog: New Feature
|
FYI @francabrera |
There was a problem hiding this comment.
I added one quick question, and I agree that it would be good to get an additional review from @francabrera.
| ) - usage_dict.get("usage_consumed_seconds", 0) | ||
|
|
||
| if limit_reached: | ||
| if not usage_dict.get("usage_limit_seconds") or usage_remaining > 0: |
There was a problem hiding this comment.
One question, what if usage_dict.get("usage_limit_seconds") is 0? In this case I believe that not usage_dict.get("usage_limit_seconds") will evaluate to True, but according to the issue we only want it to evaluate to True if the value is None. Did I follow this correctly?
| usage_dict = self._active_api_client.cloud_usage() | ||
| limit_reached = usage_dict.get("usage_limit_reached", False) | ||
| usage_remaining = usage_dict.get( | ||
| "usage_limit_seconds", usage_dict.get("usage_allocation_seconds") |
There was a problem hiding this comment.
I don't understand why usage_allocation_seconds is used here? If the instance is limited the limit will be usage_limit_seconds.
If it's there is no limit in the instance, but usage_limit_reached is true, then we always display the message for the instance's plan on the account.
3 participants
Summary
Adding warnings before job submission if the instance limit has been reached.
Details and comments
Fixes #2453