Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #489: Extend QbeastSnapshot Interface to Expose Relevant Information #492

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

JosepSampe
Copy link
Member

@JosepSampe JosepSampe commented Nov 28, 2024

Description

Add loadConfiguration in the QbeastSnapshot #489
Moved a few tests to the delta folder

Type of change

New feature

Checklist:

Here is the list of things you should do before submitting this pull request:

  • New feature / bug fix has been committed following the Contribution guide.
  • Add logging to the code following the Contribution guide.
  • Add comments to the code (make it easier for the community!).
  • Change the documentation.
  • Add tests.
  • Your branch is updated to the main branch (dependent changes have been merged).

@JosepSampe JosepSampe requested a review from osopardo1 November 28, 2024 11:48
@JosepSampe JosepSampe self-assigned this Nov 28, 2024
Copy link
Member

@osopardo1 osopardo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice to retrieve more info from QbeastSnapshot, but we should at least think about more possible info and decide about what to do with the Snapshot Management.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (039c5c0) to head (7f6fe36).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #492   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files          21       21           
  Lines         741      741           
  Branches      106      106           
=======================================
  Hits          666      666           
  Misses         75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JosepSampe JosepSampe requested a review from osopardo1 November 29, 2024 13:04
@osopardo1 osopardo1 merged commit a3ea765 into Qbeast-io:main Nov 29, 2024
3 checks passed
@JosepSampe JosepSampe deleted the extend-snapshot branch November 30, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants