-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #459: Deprecate StringHistogram for backward compatibility #485
Merged
Jiaweihu08
merged 15 commits into
Qbeast-io:main
from
osopardo1:459-rollback-string-histogram
Dec 3, 2024
Merged
Issue #459: Deprecate StringHistogram for backward compatibility #485
Jiaweihu08
merged 15 commits into
Qbeast-io:main
from
osopardo1:459-rollback-string-histogram
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiaweihu08
reviewed
Nov 26, 2024
core/src/main/scala/io/qbeast/core/transform/StringHistogramTransformation.scala
Show resolved
Hide resolved
After discussion, we agreed on:
I would update the PR in the upcoming days. |
…d conversion from old to new transformer and transformations types
Jiaweihu08
reviewed
Dec 2, 2024
Jiaweihu08
approved these changes
Dec 2, 2024
I would merge with main and then we can proceed to the squash 🐒 |
# Conflicts: # src/test/scala/io/qbeast/spark/index/model/transformer/TransformerIndexingTest.scala
Jiaweihu08
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #459
Type of change
Bug Fix to ensure backward compatibility within new versions.
Checklist:
Here is the list of things you should do before submitting this pull request:
How Has This Been Tested? (Optional)
This will be tested with an old table written with histogram transformation and version 0.7.0 of Qbeast Spark.