Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #398: Fix small overhead added during the refactoirng #436

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

JosepSampe
Copy link
Member

Description

With the current refactoring:
cpm_last_vs_ref

With the fix included in this PR:
cmp_fixed_qs_night

@JosepSampe JosepSampe requested review from cugni and osopardo1 October 9, 2024 15:30
@JosepSampe JosepSampe self-assigned this Oct 9, 2024
Copy link
Member

@osopardo1 osopardo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I am afraid that the cache can cause other problems...

@JosepSampe JosepSampe removed the request for review from cugni October 11, 2024 09:50
@JosepSampe JosepSampe requested a review from osopardo1 October 14, 2024 14:05
@osopardo1 osopardo1 merged commit 686c183 into Qbeast-io:refactor Oct 17, 2024
1 check passed
@JosepSampe JosepSampe deleted the refactoring branch October 17, 2024 13:02
JosepSampe added a commit to JosepSampe/qbeast-spark that referenced this pull request Oct 24, 2024
osopardo1 pushed a commit that referenced this pull request Oct 28, 2024
* Issue #417: Abstract the Qbeast Snapshot Module (#411)

* Issue #418: Abstract PreCommitHook and StagingDataManager (#421)

* Issue #418: Abstract RollupDataWriter and QbeastStats  (#423)

* Issue #419: Code Reorganization (#425)

* Issue #420: Create Separate Modules (#427)

* Issue #398: Fix small overhead added during the refactoring (#436)

* Issue #441: Fix data change on optimize (#442)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants