Dissalow running Scheduler with ephemeral storage when in HA mode (da…

…pr#8302) * Dissalow running with ephemeral storage Signed-off-by: Elena Kolevska <elena@kolevska.com> * Updates helm value docs Signed-off-by: Elena Kolevska <elena@kolevska.com> --------- Signed-off-by: Elena Kolevska <elena@kolevska.com> Co-authored-by: Artur Souza <asouza.pro@gmail.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
QaColony · Nov 27, 2024 · b2fc1d8 · b2fc1d8
1 parent 5594351
commit b2fc1d8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/charts/dapr/README.md b/charts/dapr/README.md
@@ -181,7 +181,7 @@ The Helm chart has the follow configuration options that can be supplied:
 | `dapr_scheduler.image.name`                   | Service docker image name (`global.registry/dapr_scheduler.image.name`)                                                                                      | `scheduler`                                       |
 | `dapr_scheduler.cluster.etcdDataDirPath`      | Mount path for persistent volume for log store in unix-like system                                                                                           | `/var/run/data/dapr-scheduler/etcd-data-dir` |
 | `dapr_scheduler.cluster.etcdDataDirWinPath`   | Mount path for persistent volume for log store in windows                                                                                                    | `C:\\etcd-data-dir`                          |
-| `dapr_scheduler.cluster.inMemoryStorage`          | When `dapr_scheduler.cluster.inMemoryStorage` is set to `true`, sets the Scheduler data directory volume to an ephermeral in-memory mount rather than a persistent volume claim. Note that this results in complete **data loss** of job data in Scheduler on restarts. | `false`                                        |
+| `dapr_scheduler.cluster.inMemoryStorage`          | When `dapr_scheduler.cluster.inMemoryStorage` is set to `true`, sets the Scheduler data directory volume to an ephermeral in-memory mount rather than a persistent volume claim. Note that this results in complete **data loss** of job data in Scheduler on restarts. It can only be enabled when running in non-HA mode.| `false`                                        |
 | `dapr_scheduler.cluster.storageClassName`     | When set, uses this class to provision the database storage volume.                                                                                          |                                              |
 | `dapr_scheduler.cluster.storageSize`          | When `dapr_scheduler.cluster.storageClassName` is set, sets the volume size request                                                                          | `1Gi`                                        |
 | `dapr_scheduler.securityContext.runAsNonRoot` | Boolean value for `securityContext.runAsNonRoot`. You may have to set this to `false` when running in Minikube                                               | `true`                                       |

diff --git a/charts/dapr/charts/dapr_scheduler/templates/dapr_scheduler_statefulset.yaml b/charts/dapr/charts/dapr_scheduler/templates/dapr_scheduler_statefulset.yaml
@@ -10,6 +10,9 @@ metadata:
     {{- end }}
 spec:
   {{- $replicas := include "dapr_scheduler.get-replicas" . }}
+  {{- if and .Values.cluster.inMemoryStorage (gt (int $replicas) 1) }}
+  {{- fail "`inMemoryStorage` can only be enabled when running in non-HA mode)" }}
+  {{- end }}
   replicas: {{ $replicas }}
   serviceName: dapr-scheduler-server
   podManagementPolicy: Parallel