Skip to content

Commit

Permalink
Change operator debug port to 443.
Browse files Browse the repository at this point in the history
Signed-off-by: joshvanl <me@joshvanl.dev>

The operator service should serve on 443 as this is the more proper TLS
port over the current 80. The injector has been updated to now inject
port 443 to sidecars. Port 80 is still being served for backwards
compatibility, but should be removed in v1.14.

Signed-off-by: joshvanl <me@joshvanl.dev>
  • Loading branch information
JoshVanL committed Nov 13, 2023
1 parent 6bf645f commit 5ed7d5a
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,18 @@ spec:
type: {{ .Values.apiService.type }}
ports:
- protocol: TCP
port: {{ .Values.ports.port }}
port: {{ .Values.ports.port }}
targetPort: {{ .Values.ports.targetPort }}

name: grpc
# Added for backwards compatibility where previous clients will attempt to
# connect on port 80.
# TOOD: @joshvanl: remove in v1.14
{{ if (ne (int .Values.ports.port) 80) }}
- protocol: TCP
port: 80
targetPort: {{ .Values.ports.targetPort }}
name: legacy
{{ end }}
---
apiVersion: v1
kind: Service
Expand All @@ -33,10 +42,10 @@ metadata:
{{ toYaml .Values.webhookService.annotations | indent 4}}
{{- end }}
spec:
selector:
app: dapr-operator
type: {{ .Values.webhookService.type }}
ports:
- port: 443
targetPort: 19443
protocol: TCP
protocol: TCP
selector:
app: dapr-operator
2 changes: 1 addition & 1 deletion charts/dapr/charts/dapr_operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ serviceReconciler:

ports:
protocol: TCP
port: 80
port: 443
targetPort: 6500

resources: {}
Expand Down
2 changes: 1 addition & 1 deletion pkg/injector/patcher/services.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ type Service struct {

var (
// Dapr API service.
ServiceAPI = Service{"dapr-api", 80}
ServiceAPI = Service{"dapr-api", 443}
// Dapr placement service.
ServicePlacement = Service{"dapr-placement-server", 50005}
// Dapr sentry service.
Expand Down

0 comments on commit 5ed7d5a

Please sign in to comment.