BUG: use size_t for holding the size of a directory, continue calculating dir size after we've hit file number limit #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciscon
force-pushed
the
use_larger_integer_for_size
branch
2 times, most recently
from
505d616
to
a6a4ca2
Compare
ciscon
changed the title
…rflow on larger directories and never clean things up. also, continue iterating through files once we've hit the limit, we will stop appending new values to the files array but continue calculating directory size. this is related to issue #135
ciscon
force-pushed
the
use_larger_integer_for_size
branch
from
a6a4ca2
to
cf48f59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rflow on larger directories and never clean things up. this is related to issue #135