Added pitts30k as an option for PCA training#39
Merged
Tobias-Fischer merged 2 commits intomainfrom Oct 15, 2021
Merged
Conversation
Contributor
Author
|
What new file? I've coded it differently to how we discussed, I'm re-using the existing patchnetvlad/tools/datasets.py to load the pitts pca data, instead of creating a replica of MSLS. |
Tobias-Fischer
requested changes
Oct 15, 2021
Contributor
Tobias-Fischer
left a comment
Tobias-Fischer
left a comment
There was a problem hiding this comment.
Looks good - just some duplicated code to be removed.
Sorry for the earlier confusion re new file - didn't look properly, that's all good.
Contributor
Author
|
Requested changes complete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new --dataset_choice arg, which allows a user to train PCA using either mapillary (default) or pitts30k. Code has been successfully tested. In response to Issue #37.